Repository navigation
Support all mysql flags while importing database - #123
Conversation
There was a problem hiding this comment.
Thanks for this first iteration, @abhijitrakas !
First of all, we should add at least 1 test in the Behat suite to test and assert that the arguments are actually passed onto mysql.
Then I have a few thoughts regarding the implementation. You have directly implemented this as part of the db import command now, but I think that every command that works by providing arguments to run the mysql binary would be abel to benefit from this improvement. So I think it would be preferable to implement this in a separate method called get_mysql_args( $assoc_args ) (similar to get_dbuser_dbpass_args( $assoc_args )), and then feed the resulting array of arguments into the run() or run_query() method.
|
@schlessera Ok, cool. So we allow only flags which are mention in MySql Doc check |
|
@abhijitrakas No, we are actually using the |
|
@schlessera Please check updated PR. |
|
Thanks for the PR, @abhijitrakas ! |
mysql flags while importing database
Support all `mysql` flags while importing database
Commit for wp-cli/ideas#112